Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Add normalMapType to materials. #16168

Merged
merged 1 commit into from
Apr 7, 2019
Merged

TypeScript: Add normalMapType to materials. #16168

merged 1 commit into from
Apr 7, 2019

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 6, 2019 •
edited
Loading

Also added many missing properties to MeshNormalMaterial.d.ts.

Friendly review request: @Methuselah96 😊

Methuselah96
Methuselah96 approved these changes Apr 6, 2019
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrdoob mrdoob added this to the r104 milestone Apr 7, 2019
@mrdoob mrdoob merged commit 73247bd into mrdoob:dev Apr 7, 2019
@mrdoob
Copy link
Owner

mrdoob commented Apr 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r104
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @mrdoob @Methuselah96