Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added MeshMatcapMaterial page. #16177

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Docs: Added MeshMatcapMaterial page. #16177

merged 3 commits into from
Apr 9, 2019

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 7, 2019

No description provided.

@Mugen87 Mugen87 requested a review from WestLangley April 7, 2019 10:41
@mrdoob mrdoob added this to the r104 milestone Apr 7, 2019
@WestLangley
Copy link
Collaborator

Thanks for this. I should have done it as part of #14828. :/

@WestLangley
Copy link
Collaborator

Color can be used to tint a MatCap, but it is not common. Most Matcaps represent both baked color and lighting. I'd set the default color to white in the docs example.

From #14828:

MeshMatcapMaterial supports maps, bump maps, normal maps, object-space normal maps, displacement maps, alpha maps, flat-shading, alpha test, skinning, morphs, and local and global clipping.

MeshMatcapMaterial does not respond to lights. (The matcap image file encodes baked lighting). It will cast a shadow onto an object that receives shadows (and shadow clipping works), but it will not self-shadow or receive shadows.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 7, 2019

Color can be used to tint a MatCap, but it is not common. Most Matcaps represent both baked color and lighting. I'd set the default color to white in the docs example.

Done!

MeshMatcapMaterial supports maps, bump maps, normal maps, object-space normal maps, displacement maps, alpha maps, flat-shading, alpha test, skinning, morphs, and local and global clipping.

I think that should be clear from the documented material properties. Listing it separately is a bit redundant from my point of view. If necessary, we should modify/overwrite the existing property docs.

MeshMatcapMaterial does not respond to lights. (The matcap image file encodes baked lighting). It will cast a shadow onto an object that receives shadows (and shadow clipping works), but it will not self-shadow or receive shadows.

Let's add this part to the description. 👍

@WestLangley
Copy link
Collaborator

MatCaps are not typically used with a diffuse map. map should not be an option in the example.

@WestLangley
Copy link
Collaborator

Aside: You know what would be great? Get rid of the grass as a texture in all the the docs. It's just horrible.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 8, 2019

map should not be an option in the example.

Done.

@mrdoob mrdoob merged commit 9d10973 into mrdoob:dev Apr 9, 2019
@mrdoob
Copy link
Owner

mrdoob commented Apr 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants