Added spherical harmonics class #16187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well of course I support merging this in. :) |
|
Thanks @WestLangley |
|
Merged this for now so we can continue to press forward. :) |
|
Thanks @WestLangley! |
|
I'm sorry it takes me so long to understand all these things. I'm slowly getting there... this week I bumped into an issue where I needed |
|
We'll get there. :-) |
|
BTW I found this interesting SH paper that Unity 3D references: http://www.ppsloan.org/publications/StupidSH36.pdf |
|
Yes, that is referenced in a comment at the top of the file. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bhouston and I worked on this in 2015, I think. I subsequently modified it.
The code is different from other versions of this file I have seen floating around the net, but in my testing, this code appears to work as expected.
I'll add this file to the build in a follow-up PR.