Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JS syntax > ECMA 2018 #25172

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Remove JS syntax > ECMA 2018 #25172

merged 4 commits into from
Dec 22, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 22, 2022

Related issue: #25168

Description

This PR removes all JS syntax > ECMA 2018 from the code base.

@sunag I see optional chaining was frequently used in node material classes. For now let's stick to the ternary operator or ordinary if statements. I've also removed the usage of static fields. These are now just added to the class namespace like in the core. Having static methods is fine, btw.

@Mugen87 Mugen87 added this to the r149 milestone Dec 22, 2022
@sunag
Copy link
Collaborator

sunag commented Dec 22, 2022

Ohh!! No problems, as soon as you merger this PR I will update this #25170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants