Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot have multiple assets in the same scope #1016

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

mrgrain
Copy link
Owner

@mrgrain mrgrain commented Dec 24, 2023

Fixes #993

@mrgrain
Copy link
Owner Author

mrgrain commented Dec 24, 2023

@Mergifyio backport v3 v4

Copy link

mergify bot commented Dec 24, 2023

backport v3 v4

✅ Backports have been created

@mergify mergify bot merged commit 6777ba2 into v5 Dec 24, 2023
20 checks passed
@mergify mergify bot deleted the mrgrain/fix/cannot-have-multiple-assets-in-same-scope branch December 24, 2023 15:25
mergify bot pushed a commit that referenced this pull request Dec 24, 2023
Fixes #993

(cherry picked from commit 6777ba2)

# Conflicts:
#	src/source.ts
mergify bot pushed a commit that referenced this pull request Dec 24, 2023
Fixes #993

(cherry picked from commit 6777ba2)

# Conflicts:
#	src/source.ts
mrgrain added a commit that referenced this pull request Dec 24, 2023
mergify bot added a commit that referenced this pull request Dec 24, 2023
…1017)

This is an automatic backport of pull request #1016 done by [Mergify](https://mergify.com).

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
mergify bot added a commit that referenced this pull request Dec 24, 2023
…1017)

This is an automatic backport of pull request #1016 done by [Mergify](https://mergify.com).

---

<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

(cherry picked from commit 40e53e0)

# Conflicts:
#	src/code.ts
#	src/utils.ts
mrgrain pushed a commit that referenced this pull request Dec 24, 2023
…1017)

This is an automatic backport of pull request #1016 done by [Mergify](https://mergify.com).

---

<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

(cherry picked from commit 40e53e0)
mergify bot pushed a commit that referenced this pull request Dec 24, 2023
Same as #1016 but for `TypeScriptCode` (not just `TypeScriptSource`).

This issue is unlikely to occur and was only triggered when `TypeScriptCode.bind()` was invoked directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: There is already a Construct with name 'TypeScriptSource' in BucketDeployment
1 participant