Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Add rand_range #269

Merged
merged 1 commit into from
Oct 10, 2024
Merged

- Add rand_range #269

merged 1 commit into from
Oct 10, 2024

Conversation

zeotuan
Copy link
Contributor

@zeotuan zeotuan commented Oct 7, 2024

Proposed changes

Related to #88

  • Add rand_range which Samples from ∼U(α,β)
  • Add rand_range and range_laplace test

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

This also make math functions: rand_laplace and rand_range available by importing quinn

@zeotuan
- Add rand_range
6d3b951 
- Add rand_range + range_laplace test
@zeotuan
Copy link
Contributor Author

zeotuan commented Oct 10, 2024

@SemyonSinchenko What do you think about this?

SemyonSinchenko
SemyonSinchenko approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SemyonSinchenko SemyonSinchenko merged commit f538672 into mrpowers-io:main Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeotuan @SemyonSinchenko