The foreignNames multiverseid field is now an integer, see issue #12

mtgjson · Sep 14, 2015 · 0c68c23 · 0c68c23
1 parent 8ba5e70
commit 0c68c23
Show file tree

Hide file tree

Showing 87 changed files with 105 additions and 89 deletions.
diff --git a/build/rip.js b/build/rip.js
@@ -486,7 +486,7 @@ function addForeignNamesToCard(card, cb)
  {
  var languageHref = cardRow.querySelector("td:nth-child(1) a").getAttribute("href");
  var foreignMultiverseid = querystring.parse(languageHref.substring(languageHref.indexOf("?")+1)).multiverseid;
- card.foreignNames.push({language : language, name : foreignCardName, multiverseid : foreignMultiverseid});
+ card.foreignNames.push({language : language, name : foreignCardName, multiverseid : +foreignMultiverseid});
  }
  });
 

diff --git a/json/10E.json b/json/10E.json
diff --git a/json/5DN.json b/json/5DN.json
diff --git a/json/7ED.json b/json/7ED.json
diff --git a/json/8ED.json b/json/8ED.json
diff --git a/json/9ED.json b/json/9ED.json
diff --git a/json/ALA.json b/json/ALA.json
diff --git a/json/APC.json b/json/APC.json
diff --git a/json/ARB.json b/json/ARB.json
diff --git a/json/ARC.json b/json/ARC.json
diff --git a/json/AVR.json b/json/AVR.json
diff --git a/json/BNG.json b/json/BNG.json
diff --git a/json/BOK.json b/json/BOK.json
diff --git a/json/C13.json b/json/C13.json
diff --git a/json/C14.json b/json/C14.json
diff --git a/json/CHK.json b/json/CHK.json
diff --git a/json/CMD.json b/json/CMD.json
diff --git a/json/CNS.json b/json/CNS.json
diff --git a/json/CON.json b/json/CON.json
diff --git a/json/CSP.json b/json/CSP.json
diff --git a/json/DD2.json b/json/DD2.json
diff --git a/json/DDE.json b/json/DDE.json
diff --git a/json/DDF.json b/json/DDF.json
diff --git a/json/DDG.json b/json/DDG.json
diff --git a/json/DDH.json b/json/DDH.json
diff --git a/json/DDI.json b/json/DDI.json
diff --git a/json/DDJ.json b/json/DDJ.json
diff --git a/json/DDK.json b/json/DDK.json
diff --git a/json/DDL.json b/json/DDL.json
diff --git a/json/DDM.json b/json/DDM.json
diff --git a/json/DDN.json b/json/DDN.json
diff --git a/json/DDO.json b/json/DDO.json
diff --git a/json/DDP.json b/json/DDP.json
diff --git a/json/DGM.json b/json/DGM.json
diff --git a/json/DIS.json b/json/DIS.json
diff --git a/json/DKA.json b/json/DKA.json
diff --git a/json/DPA.json b/json/DPA.json
diff --git a/json/DST.json b/json/DST.json
diff --git a/json/DTK.json b/json/DTK.json
diff --git a/json/EVE.json b/json/EVE.json
diff --git a/json/FRF.json b/json/FRF.json
diff --git a/json/FRF_UGIN.json b/json/FRF_UGIN.json
diff --git a/json/FUT.json b/json/FUT.json
diff --git a/json/GPT.json b/json/GPT.json
diff --git a/json/GTC.json b/json/GTC.json
diff --git a/json/HOP.json b/json/HOP.json
diff --git a/json/INV.json b/json/INV.json
diff --git a/json/ISD.json b/json/ISD.json
diff --git a/json/JOU.json b/json/JOU.json
diff --git a/json/JUD.json b/json/JUD.json
diff --git a/json/KTK.json b/json/KTK.json
diff --git a/json/LGN.json b/json/LGN.json
diff --git a/json/LRW.json b/json/LRW.json
diff --git a/json/M10.json b/json/M10.json
diff --git a/json/M11.json b/json/M11.json
diff --git a/json/M12.json b/json/M12.json
diff --git a/json/M13.json b/json/M13.json
diff --git a/json/M14.json b/json/M14.json
diff --git a/json/M15.json b/json/M15.json
diff --git a/json/MBS.json b/json/MBS.json
diff --git a/json/MM2.json b/json/MM2.json
diff --git a/json/MOR.json b/json/MOR.json
diff --git a/json/MRD.json b/json/MRD.json
diff --git a/json/NPH.json b/json/NPH.json
diff --git a/json/ODY.json b/json/ODY.json
diff --git a/json/ONS.json b/json/ONS.json
diff --git a/json/ORI.json b/json/ORI.json
diff --git a/json/PC2.json b/json/PC2.json
diff --git a/json/PLC.json b/json/PLC.json
diff --git a/json/PLS.json b/json/PLS.json
diff --git a/json/RAV.json b/json/RAV.json
diff --git a/json/ROE.json b/json/ROE.json
diff --git a/json/RTR.json b/json/RTR.json
diff --git a/json/S00.json b/json/S00.json
diff --git a/json/SCG.json b/json/SCG.json
diff --git a/json/SHM.json b/json/SHM.json
diff --git a/json/SOK.json b/json/SOK.json
diff --git a/json/SOM.json b/json/SOM.json
diff --git a/json/THS.json b/json/THS.json
diff --git a/json/TOR.json b/json/TOR.json
diff --git a/json/TSB.json b/json/TSB.json
diff --git a/json/TSP.json b/json/TSP.json
diff --git a/json/UNH.json b/json/UNH.json
diff --git a/json/WWK.json b/json/WWK.json
diff --git a/json/ZEN.json b/json/ZEN.json
diff --git a/util/tmp.js b/util/tmp.js
@@ -35,6 +35,8 @@ tiptoe(
 
 function checkSet(setCode, cb)
 {
+ base.info("Processing %s", setCode);
+
  tiptoe(
  function getJSON()
  {
@@ -46,14 +48,20 @@ function checkSet(setCode, cb)
 
  set.cards.forEach(function(card)
  {
- if(card.name==="Grave Titan")
+ if(card.hasOwnProperty("foreignNames"))
  {
- base.info("%s: %s : %s", setCode, card.name, card.artist);
+ card.foreignNames.forEach(function(foreignName)
+ {
+ if(foreignName.multiverseid)
+ foreignName.multiverseid = +foreignName.multiverseid;
+ else
+ delete foreignName.multiverseid;
+ });
  }
  });
 
- //fs.writeFile(path.join(__dirname, "..", "json", setCode + ".json"), JSON.stringify(set), {encoding : "utf8"}, this);
- this();
+ fs.writeFile(path.join(__dirname, "..", "json", setCode + ".json"), JSON.stringify(set), {encoding : "utf8"}, this);
+ //this();
  },
  function finish(err)
  {

diff --git a/web/changelog.json b/web/changelog.json
@@ -1,4 +1,12 @@
 [
+ {
+ "version": "3.2.3",
+ "when": "2015-09-14",
+ "changes": [
+ "The 'foreignNames' 'multiverseid' field is now correctly an integer rather than a string."
+ ],
+ "updatedSetFiles" : ["10E-x","5DN-x","7ED-x","8ED-x","9ED-x","ALA-x","APC-x","ARB-x","ARC-x","AVR-x","BNG-x","BOK-x","C13-x","C14-x","CHK-x","CMD-x","CNS-x","CON-x","CSP-x","DD2-x","DDE-x","DDF-x","DDG-x","DDH-x","DDI-x","DDJ-x","DDK-x","DDL-x","DDM-x","DDN-x","DDO-x","DDP-x","DGM-x","DIS-x","DKA-x","DPA-x","DST-x","DTK-x","EVE-x","FRF-x","FRF_UGIN-x","FUT-x","GPT-x","GTC-x","HOP-x","INV-x","ISD-x","JOU-x","JUD-x","KTK-x","LGN-x","LRW-x","M10-x","M11-x","M12-x","M13-x","M14-x","M15-x","MBS-x","MM2-x","MOR-x","MRD-x","NPH-x","ODY-x","ONS-x","ORI-x","PC2-x","PLC-x","PLS-x","RAV-x","ROE-x","RTR-x","S00-x","SCG-x","SHM-x","SOK-x","SOM-x","THS-x","TOR-x","TSB-x","TSP-x","UNH-x","WWK-x","ZEN-x"]
+ },
  {
  "version": "3.2.2",
  "when": "2015-09-08",