Skip to content
This repository has been archived by the owner on Dec 21, 2018. It is now read-only.

Cards without mana costs don't have 'cmc' data #118

Closed
vslashg opened this issue Jan 21, 2016 · 4 comments
Closed

Cards without mana costs don't have 'cmc' data #118

vslashg opened this issue Jan 21, 2016 · 4 comments
Milestone

Comments

@vslashg
Copy link

vslashg commented Jan 21, 2016

This is mostly applicable to lands, but can happen to other cards (Ancestral Vision is a non-land example).

Cards without mana costs have a converted mana cost of 0 (rule 202.3a), and it would be useful if CMC data were provided for all cards.

@Garbee
Copy link
Contributor

Garbee commented Jan 21, 2016

How exactly would this be useful? You can easily program for this occurance when reading the data.

@vslashg
Copy link
Author

vslashg commented Jan 22, 2016

Clients can work around missing data, but should they be expected to? Ancestral Vision and Memnite are both CMC 0. Why does one card's entry provide this data and the other not?

@bakert
Copy link
Contributor

bakert commented Sep 28, 2016

An example of how this might be useful. magidex.com uses mtgjson data and currently "cmc<1" in a search query does not find lands. If the client programmer is aware of this omission they can work around it but they have to know. Given that the CMC of a land is 0 and not NULL I think the data should reflect that. I just added some code to work around this in my own project.

http://magidex.com/ and search for "cmc<1 t:land" (github mangling the URL if I paste it directly!)

@gwax
Copy link
Contributor

gwax commented Jul 24, 2017

Fixed by #413

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants