Skip to content
This repository has been archived by the owner on Dec 21, 2018. It is now read-only.

Missing translations from subsequent Gatherer pages #144

Closed
bra1n opened this issue Apr 4, 2016 · 4 comments
Closed

Missing translations from subsequent Gatherer pages #144

bra1n opened this issue Apr 4, 2016 · 4 comments
Milestone

Comments

@bra1n
Copy link
Contributor

bra1n commented Apr 4, 2016

Hi,

I just noticed that MTGJSON doesn't seem to pull any translations from Gatherer beyond the first page.
For example, Wastes lacks translations for Spanish, Russian and Chinese Simplified, which are all shown on the second page on Gatherer. This is probably also the case for a couple of other cards, though I only noticed it on Wastes so far.
Can you fix this, please? :)

Thanks,
bra1n

@ynerant
Copy link
Contributor

ynerant commented Apr 4, 2016

I noticed this problem a long time ago, I wanted to create an issue now, but I was too late.
Yes, there aren't all foreignNames, you can see all basic lands, there are only 25 different printings, while basic lands can be 100 times printed (5 different illustrations (BFZ) * 2 (full-art/normal; BFZ/ZEN) * 10 languages).

@ynerant
Copy link
Contributor

ynerant commented Jun 11, 2016

I tried to put a little fix, that works but not very optimized : #173

@bra1n
Copy link
Contributor Author

bra1n commented Jul 26, 2016

Bump, any news on this?

@ZeldaZach
Copy link
Member

Using scryfall's data now for translations. Look to V4 for that impl! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants