This repository has been archived by the owner on Dec 21, 2018. It is now read-only.
Add DDT and IMA and rebuild, fix a mistake with Ixalan's set code for standard, update the howto, fix a bug (?) with compareRelease.js, make Ormendahl's CMC = 0 #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should almost certainly not be merged, yet. More on that in a bit.
I started this journey wanting to add a little change to rip.js to make Ormendahl, Profane Prince's CMC be zero and not null. It's our oldest outstanding bug: PennyDreadfulMTG/Penny-Dreadful-Tools#138, #435.
But to do the necessary rebuilding I had to add missing sets DDT and IMA. I added these and that then touched basically every set ever either because I messed something up or because IMA has sets from all of history or because WotC just added support for Simplified Chinese or ... something. I'm not sure.
I updated
howto.txt
as I went because it seemed out of date. I put that in a separate commit to the big one so it can be more easily reviewed.While I was in there doing all this I changed the standard legal codes to 'XLN' instead of 'IXN' which I suppose is part of the cause of #479. This change is a (tiny) separate commit from all the rebuilding. I also regenerated (among many others) SOI and EMN which should shake loose the other part of #479.
I also found and logged #482, #483 and #485 as I was going through the process. I ended up re-entering the process manually about ten times. Maybe more. The number of sets with "tainted fields" started reducing at some point and I persevered. We should maybe have the machine do this automatically.
I ignored a bunch of output like this:
I don't know how bad that is or if it's normal/not a big deal.
I ended up with a lot of output to do with basic lands and Simplified Chinese. I don't know if this is because I did something wrong or because something changed in Gatherer or somewhere else. Or just because IMA and/or DDT contain basic lands!
I had to change compareRelease.js because it wanted to look in web/json/*.json and my output was in json/ in the root. That change is in a separate commit for easier review. I wonder if this is to do with the symlinks mentioned in the README.
I didn't entirely complete the run of compareRelease.js because of #484 but my /tmp/changeSets.json had a looooot of set codes in it so I proceeded to pul request. Would love to understand that better.
The one reason I know why this almost certainly shouldn't be merged is because for some reason all rulings for all cards now seem to have the date 2017-11-17 (the release date of IMA?). Any advice on why that might be would be gratefully received.
I also committed package-lock.json to source control as recommended by npm. I'm pretty sure that was dumb because you'd have it in there if you wanted it in there I guess. But it's also not in a .gitignore so I don't know. Given #485 it's probably a particularly bad package-lock to commit.
Please let me know anything obvious that I've done wrong and I'll fix. It will be good to have the new sets and fix Standard legality and, of course, set Ormendahl's CMC to 0!
Or feel free to use my set definitions and code/howto changes and make a working set of changes!