adding tests for blake3 and fixing an error handling bug.

[laudiacay]

Re-exporting blake3 constants in the right places so we can support it elsewhere (like go-verifcid, so that I can add support for approving fixed-length blake3 as a "good hash" there 😄 ) Draft because there are no tests yet.

edit: it doesn't exactly do this anymore, check comments below...

[laudiacay]

tests passed. I also found a bug in what was being displayed for ErrInconsistentLen and fixed the message to make a little more sense, and added a few comments for clarity... the way the logic was before, it was just gonna print like the same number twice in the "expected blah got bleh" message no matter what.

[laudiacay]

@Kubuxu @aschmahmann ready 2 go when u r :)

[Jorropo]

The ErrInconsistentLen change looks good to me thx, but I don't think we need the rest.

[laudiacay]

ok i changed the title to fit. i'm gonna leave the new blake3 tests too. committing now.

[Jorropo]

@laudiacay do the tests passes ?

I think you need to register blake3 in the test suite else they wont find the hasher. Simply add this line to your imports (in the tests) _ "github.com/multiformats/go-multihash/register/blake3", naming an import _ (the blank indentifier) will run of it's init functions without adding it's exports to the file scope.

[laudiacay]

register/all gets blake3 and the tests get register/all!

[Jorropo]

Ok good mb

[Jorropo]

SGTM (need green CI first) (I don't have merge powers here)

[marten-seemann]

Re-exporting blake3 constants in the right places so we can support it elsewhere

I don't see that anywhere. As far as I can tell, this PR is 1. changing the error messages and 2. adding blake3 tests. Am I missing something?

[Jorropo]

I don't see that anywhere.

@marten-seemann

It used to do it but I've asked for it to be removed, I think people that want blake3 can just import _ "github.com/multiformats/go-multihash/register/blake3"

[laudiacay]

@marten-seemann it's not doing that anymore- it's fixing an error message and adding tests. I was doing that before but then @Jorropo let me know that that was unnecessary :P didn't quite understand go imports with side effects until just now

[laudiacay]

are we good to merge?

[aschmahmann]

@laudiacay is this PR just:

1. Change the error message to give more info
2. Rename a variable to be clearer
3. Add some blake3 tests

If so LGTM, although if you could squash the commits together with a clear commit message that'd be great.

[laudiacay]

Yep done

[Jorropo]

LGTM

[Jorropo]

Notes for a future PR, IMO, this error should wrap io.UnexpectedEOF.