Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

refactor: default to base32 encoding for v1 CIDs #89

Merged
merged 3 commits into from
May 9, 2019
Merged

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented May 8, 2019

This switches the default encoding for v1 CIDs from base58btc to base32. See ipfs/js-ipfs#1995 for details.

BREAKING CHANGE: The default string encoding for v1 CIDs has changed from base58btc to base32.

This switches the default encoding for v1 CIDs from base58btc to base32. See ipfs/js-ipfs#1995 for details.

BREAKING CHANGE: The default string encoding for v1 CIDs has changed from base58btc to base32.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@ghost ghost assigned alanshaw May 8, 2019
@ghost ghost added the status/in-progress In progress label May 8, 2019
src/index.js Show resolved Hide resolved
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the README that now base32 is the default for v1 CIDs.

@alanshaw alanshaw requested a review from vmx May 9, 2019 10:33
Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vmx
Copy link
Member

vmx commented May 9, 2019

I can't put in an inline comment, there's still the sentence "The string form of CIDs currently defaults to base58btc" in the README. I think that should also be updated.

@alanshaw
Copy link
Member Author

alanshaw commented May 9, 2019

Good now @vmx?

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I'll leave the merging to you as you have a better overview over the related PRs and when to merge.

@vmx vmx merged commit d1ee91b into master May 9, 2019
@vmx vmx deleted the refactor/b32cidv1 branch May 9, 2019 12:52
@ghost ghost removed the status/in-progress In progress label May 9, 2019
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants