Add UTP and WebSockets to the mix #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 +67,7 @@ test('basic stuff works', function (t) { | |||
| var tests = Array.from(arguments).slice(1) | |||
| tests.forEach(function (test) { | |||
| test.forEach(function (testcase) { | |||
| t.equal(p.matches(testcase), false, 'should not have matched: ' + testcase + ' ' + p) | |||
| t.equal(p.matches(testcase), false, 'should not have matched: ' + testcase + ' ' + testcase) | |||
There was a problem hiding this comment.
this change doesnt seem right to me. we're printing that testcase should equal testcase?
There was a problem hiding this comment.
you're right. I wanted to print 'test', because printing 'p' was just printing [Object object].
|
One comment, then LGTM |
daviddias
force-pushed
the
feature/utp+websockets
branch
from
9d81683
to
560f8de
Compare
|
Thank you! |
whyrusleeping
added a commit
that referenced
this pull request
Mar 14, 2016
Add UTP and WebSockets to the mix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whyrusleeping I've updated js-multiaddr to support uTP (and WebSockets, HTTP and so on) and here is the PR to make js-mafmt to make it understand uTP and WebSockets as well (as I need it for libp2p).