Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

remove constants.js size #73

Closed
hugomrdias opened this issue Mar 16, 2020 · 3 comments · Fixed by #76
Closed

remove constants.js size #73

hugomrdias opened this issue Mar 16, 2020 · 3 comments · Fixed by #76

Comments

@hugomrdias
Copy link
Member

Any chance we can reduce the size of the constants.js file ?

/cc @vmx @jacobheun
@hugomrdias hugomrdias mentioned this issue Mar 16, 2020
Closed
56 tasks
@vmx
Copy link
Member

vmx commented Mar 16, 2020

js-multicodec could be used, which is a dependency on a lot of things that use js-multihash anyway.

@hugomrdias
Copy link
Member Author

that would be perfect what about the codes and sizes ?

@vmx
Copy link
Member

vmx commented Mar 16, 2020

The codes are part of js-multicodec, the sizes are not (and i also don't find the sizes generally useful. Without checking the code, I would imagine we could just get rid of the default sizes).

@jacobheun jacobheun mentioned this issue Mar 23, 2020
Open
@hugomrdias hugomrdias mentioned this issue Apr 6, 2020
Merged
hugomrdias added a commit that referenced this issue Apr 21, 2020
@hugomrdias
feat: updates multihash table
852ce6b 
- adds script to auto update
- reduces bundle size by having only one explicit table ( 3kb gziped diff )
- remove defaultLengths seems to not be used and multicodec tables doesn't have it

closes #73

BREAKING CHANGE: defaultLengths removed, skein is now lowercase
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: updates multihash table multiformats/js-multihash
2 participants
@vmx @hugomrdias