Adding multicodec for aes-gcm #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding aes-gcm-256 multicodec with category encryption.
vmx
reviewed
Feb 14, 2023
There was a problem hiding this comment.
Sounds reasonable to me. I've had a brief look at the corresponding section in the Double Hash DHT spec. Please note that the encoded value won't be 0xa5, but the varint of it: 0xa501.
Though I'd like to get input from others as this introduces a new category.
rvagg
requested changes
Feb 20, 2023
There was a problem hiding this comment.
Since this opens the door to a massive number of permutations, all under the same "encryption" category, I think this should go later in the table where there is a sizeable chunk of free space.
Otherwise I don't mind a new category .. there's just a lot of them and I can imagine the inevitable PR with someone adding all the possible permutations ..
code varint 8192 (0x2000) => 10000000 01000000 (0x8040)
|
Moved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
aes-gcm-256multicodec. Please edit if the categoryencryptiondoesn't fit here.aes-gcm-256is a payload format: the 12-byte Initialization Vector (IV) is concatenated with a payload encrypted using AES in Galois/Counter Mode, using a 256-bit key and the 12 byte IV.This multicodec is required for the Double Hash DHT ipfs/specs#373