Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isElementInWater add support for objects elements #3740

Open
1 task done
Proxy-99 opened this issue Sep 20, 2024 · 2 comments
Open
1 task done

isElementInWater add support for objects elements #3740

Proxy-99 opened this issue Sep 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Proxy-99
Copy link
Contributor

Is your feature request related to a problem? Please describe.

isElementInWater does not support objects

Describe the solution you'd like

it should work as vehicles api since objects has a Bounding Box to similar logic could be followed

Describe alternatives you've considered

No response

Additional context

No response

Security Policy

  • I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.
@Proxy-99 Proxy-99 added the enhancement New feature or request label Sep 20, 2024
@CrosRoad95
Copy link
Contributor

CrosRoad95 commented Sep 20, 2024

Woudln't be smart from api point of view to provide functions to check if given point or volume is inside water and function to get all water volumes? because that is probably enough to implement all sort of water related function

And then deprecate isElementInWater, move it implementation to lua ( simillar to "inspect" function )

@Fernando-A-Rocha
Copy link
Contributor

Woudln't be smart from api point of view to provide functions to check if given point or volume is inside water and function to get all water volumes? because that is probably enough to implement all sort of water related function

And then deprecate isElementInWater, move it implementation to lua ( simillar to "inspect" function )

That would indeed be very smart and modern. +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants