Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening external url #3758

Open
1 task done
Xenius97 opened this issue Sep 30, 2024 · 9 comments
Open
1 task done

Opening external url #3758

Xenius97 opened this issue Sep 30, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@Xenius97
Copy link
Contributor

Is your feature request related to a problem? Please describe.

A function to open an URL in external browser.
When function is called, MTA goes automatically minimized and URL should open in default browser

Describe the solution you'd like

openExternalURL('https://google.com/') -- this will open google.com in windows default browser

Describe alternatives you've considered

No response

Additional context

No response

Security Policy

  • I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.
@Xenius97 Xenius97 added the enhancement New feature or request label Sep 30, 2024
@MegadreamsBE
Copy link
Member

Huge security risk. This should never be introduced

@TracerDS
Copy link
Contributor

Huge security risk. This should never be introduced

Unless we do the same what discord does: dialog for the user to either accept it or refuse it

@Xenius97
Copy link
Contributor Author

Huge security risk. This should never be introduced

I don't think so, if user need to accept it like requestBrowserDomains()
or only allow whitelisted domains

@MegadreamsBE
Copy link
Member

Huge security risk. This should never be introduced

Unless we do the same what discord does: dialog for the user to either accept it or refuse it

True. We'll need to make sure to display the entire URL, and a clear warning that it can be dangerous.

Huge security risk. This should never be introduced

I don't think so, if user need to accept it like requestBrowserDomains() or only allow whitelisted domains

Combination between this and Tracer's proposal perhaps. Although the dialog Tracer proposes should be sufficient. Whitelisting an entire domain, and then just letting it happen at any point thereafter would still be a bad idea.

@PlatinMTA
Copy link
Contributor

This was requested before... i hope this time we actually allow it

we just need to prompt the user before opening the url is not that problematic

@Fernando-A-Rocha
Copy link
Contributor

The web is full of url redirects. I think having this with a prompt before opening the url is more than enough

@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Oct 1, 2024

Related to previously rejected feature: #2409

@CrosRoad95
Copy link
Contributor

CrosRoad95 commented Oct 1, 2024

Huge security risk. This should never be introduced

Skill issue, add prompt showned every time you try do this + require first to add url to whitelist. - discord can do this, you can too

And whitelist should be per server ( downloaded resources too ) because of https://developer.chrome.com/blog/http-cache-partitioning?hl=en

The same should apply for my pr with drag and drop onto mta window, add prompt, configuration ( by default disabled ).

If someone is stupid he get hacked like recently i even reported server to hosting provider due to owner stupidity.

I would personally use it to open website to documentation of my server

AND ALSO, if we talking about security risk, why noobody over the years configured some tool to find memory leak, to find where mta write/read outside buffers?

@Inder00
Copy link
Contributor

Inder00 commented Oct 1, 2024

Closed in #2409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants