Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mux-r2.8.0 sends "Player is accessed on the wrong thread" warning #12

Closed
kai-sarawut opened this issue Jan 23, 2019 · 11 comments
Closed

Comments

@kai-sarawut
Copy link

kai-sarawut commented Jan 23, 2019

After updating version to mux-r2.8.0 I notice that "Player is accessed on the wrong thread" warning is sent repeatedly in Logcat console. The last version has no this issue so I suspect that this could possibly affect ExoPlayer performance on my application? Or this is a known issue? How can I handle with this issue? Thanks.

@kai-sarawut
Copy link
Author

kai-sarawut commented Jan 23, 2019

messageimage_1548225295823

@jsanford8
Copy link
Collaborator

Hi @kai-sarawut - as of right now, this should be a warning based on the threading model that ExoPlayer has taken as of ExoPlayer 2.9.0, but we are looking at how we can address this moving forward. Are you seeing this impact playback within the application?

@kai-sarawut
Copy link
Author

Hi, @jsanford8. Good to know this issue is going be addressed.
At first I had playback related issue on the application and started to investigate the real problem til found out the issue caused by integration with another third-party code. Until now I don't have a visible impact on the application with this issue, but I wonder this could have an effect on player in the future.

@jsanford8
Copy link
Collaborator

Hi @kai-sarawut - absolutely! This is why we're looking into fixing this moving forward, because Google may change this into a hard exception in the future, potentially, or some other issue. I will provide updates on this issue as we have them.

@OMArikan
Copy link

Hi @jsanford8 - my suggestion is letting pass Looper on constructor of "MuxStatsExoPlayer" likewise "ExoPlayerFactory.newSimpleInstance()".
SimpleExoPlayer.eventHandler is private final and you can't reach it from ExoPlayer object that passed in your constructor . Please don't use "Looper.getMainLooper()" because not everyone using default Looper in ExoPlayer like me.
Looking to hear from you soon 2.9.x update.

@kai-sarawut
Copy link
Author

kai-sarawut commented Feb 1, 2019

I think it's a thread issue in an operation in the libs.

@jsanford8
Copy link
Collaborator

@OMArikan thanks for the suggestion, we'll look into that!

@kai-sarawut - We do have an internal task that loops, querying the player's current playhead position, similar to this comment on ExoPlayer's issue about threading: google/ExoPlayer#4463 (comment). We're trying to come up with a way to do this correctly.

@OMArikan
Copy link

OMArikan commented May 6, 2019

Hi @jsanford8 it's been so long we have not heard any updates from you. Waiting mux-r2.9.0.aar.

@stufan
Copy link

stufan commented Jun 10, 2019

I integrated mux-2.8.0 version and experience exactly the same issue. ExoPlayer version is 2.10.1 (the latest as of today). Any updates?

@sezn
Copy link

sezn commented Aug 12, 2019

Yeah, it's very disappointed, two years late no new Version. It s just a warning, so, if it s just mux who dont work has expected... no matter.

@jsanford8
Copy link
Collaborator

fixed by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants