Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text input doesn't bring up virtual keyboard on mobile #29

Closed
stmdhms opened this issue May 21, 2021 · 11 comments · Fixed by #279
Closed

Text input doesn't bring up virtual keyboard on mobile #29

stmdhms opened this issue May 21, 2021 · 11 comments · Fixed by #279
Labels
help wanted Extra attention is needed

Comments

@stmdhms
Copy link

stmdhms commented May 21, 2021

This was recently fixed in egui itself (emilk/egui#247), but doesn't currently work correctly in bevy_egui.

@vihdzp
Copy link
Contributor

vihdzp commented May 21, 2021

This would be solved by #27.

@mvlabat
Copy link
Owner

mvlabat commented May 22, 2021

I'm afraid just upgrading to 0.12 doesn't fix it. I guess we need to port the changes that were done in emilk/egui#253 to bevy_egui. Unfortunately, I'm not able to look into those myself atm, but I'm happy to accept a PR if anyone wants to tackle that.

@mvlabat mvlabat added the help wanted Extra attention is needed label May 29, 2021
@miketwenty1
Copy link

Is it still possible to bring up the mobile keyboard with a WASM build?

@mvlabat
Copy link
Owner

mvlabat commented Dec 27, 2022

Still impossible, unfortunately. If anyone wants to make a PR for this, I'll gladly accept it.

@oscrim
Copy link
Contributor

oscrim commented May 10, 2023

Hello, Ive been working on this on this branch (which also containts the work from #180 ). Due to winit lacking support for composition events in the web (as can be seen here) I excluded the event listeners for them as it currently sends them all out at once when the composition ends which causes unwanted behavior.

I can create a pull request once #180 is done

@v-kat
Copy link
Contributor

v-kat commented Mar 2, 2024

@oscrim did your code fix mobile keyboard issues with bevy_egui? I wasn't sure if this was an IME issue that has to be explored at a lower level.

@oscrim
Copy link
Contributor

oscrim commented Mar 2, 2024

It was more of a work around than a proper fix. It's been a while since I looked at it

@v-kat
Copy link
Contributor

v-kat commented Mar 2, 2024

Do you think it's something you could eventually upstream? I was still trying to understand if there was a bug in IME somewhere or if some of the code from egui needed to be adapted/bridged to bevy. (Maybe from https:/emilk/egui/blob/master/crates/eframe/src/web/text_agent.rs )

I'm also curious about @Vrixyz opinion.

@v-kat
Copy link
Contributor

v-kat commented Mar 7, 2024

I might just steal your code and maybe try to upstream it >.> @oscrim

@oscrim
Copy link
Contributor

oscrim commented Mar 7, 2024

I might just steal your code and maybe try to upstream it >.> @oscrim

@v-kat please do!

I don't think the ime not working is a bug, if I interpret the docs correctly there is no ime support on android/ios/web in bevy or winit
https://docs.rs/bevy_window/latest/bevy_window/struct.Window.html#structfield.ime_enabled

https://docs.rs/winit/latest/winit/event/enum.WindowEvent.html#variant.Ime

@mvlabat
Copy link
Owner

mvlabat commented Oct 6, 2024

Implemented in bevy_egui 0.30

@mvlabat mvlabat closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants