Skip to content

Commit

Permalink
Update test rather than extra JS code.
Browse files Browse the repository at this point in the history
Whether the comma is escaped or not doesn’t matter.
  • Loading branch information
dracos committed Jan 18, 2019
1 parent cff0510 commit 9a79ba3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion .cypress/cypress/integration/around_filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('Around page filtering and push state', function() {
cy.wait('@update-results');
cy.contains('1 to 6 of 6');
cy.contains('Street light not working');
cy.url().should('include', 'status=closed%2Cfixed');
cy.url().should('include', 'status=closed,fixed');
cy.get('#status_2').should('be.checked');
});

Expand Down
11 changes: 0 additions & 11 deletions web/js/map-OpenLayers.js
Original file line number Diff line number Diff line change
Expand Up @@ -943,17 +943,6 @@ OpenLayers.Control.PermalinkFMS = OpenLayers.Class(OpenLayers.Control.Permalink,
}

var params = this.createParams(center, zoom);
// Roundtripping a param containing urlencoded commas through
// createParams and getParameterString results in the commas
// becoming un-urlencoded, so let's avoid this by joining the arrays
// with commas here, which will then be urlencoded correctly by
// getParameterString.
if (OpenLayers.Util.isArray(params.status)) {
params.status = params.status.join(",");
}
if (OpenLayers.Util.isArray(params.filter_category)) {
params.filter_category = params.filter_category.join(",");
}

// Strip out the ugly OpenLayers layers state string
delete params.layers;
Expand Down

0 comments on commit 9a79ba3

Please sign in to comment.