Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving existing report pin does not reset areas #2181

Closed
davea opened this issue Jul 3, 2018 · 0 comments
Closed

Moving existing report pin does not reset areas #2181

davea opened this issue Jul 3, 2018 · 0 comments
Assignees
@davea
Labels
Bug

Comments

@davea
Copy link
Member

davea commented Jul 3, 2018

Not an urgent one this.. but a bug nonetheless.
If a report is moved across a divisional boundary it is still associated with the original division.
See: https://fixmystreet.oxfordshire.gov.uk/reports/Oxfordshire/North+Hinksey

screen shot 2018-07-03 at 10 07 05

and note the pin way out to the right.
It’s this report: https://fixmystreet.oxfordshire.gov.uk/report/1329287
Which was moved from within North Hinksey into Oxford.
@davea davea added the Next label Jul 5, 2018
@dracos dracos added Next and removed Options labels Sep 10, 2018
@davea davea added Current and removed Next labels Oct 15, 2018
@davea davea self-assigned this Oct 15, 2018
@davea davea added In progress and removed Current labels Oct 15, 2018
davea added a commit that referenced this issue Oct 15, 2018
@davea
Update areas when moving report pin
182922d 
Fixes #2181.
davea added a commit that referenced this issue Oct 16, 2018
@davea
Update areas when moving report pin
ab9fd27 
The change in report_inspect.t from WODC to Oxford City was necessary
because moving reports to a location not in Mock::MapIt was resulting in
an empties bodies_str in the "test category/body changes" test.

Fixes #2181.
@davea davea mentioned this issue Oct 16, 2018
Closed
2 tasks
@ghost ghost added Reviewing and removed In progress labels Oct 16, 2018
@dracos dracos added Reviewed and removed Reviewing labels Oct 17, 2018
davea added a commit that referenced this issue Oct 17, 2018
@davea
Update areas when moving report pin
117124a 
The change in report_inspect.t from WODC to Oxford City was necessary
because moving reports to a location not in Mock::MapIt was resulting in
an empties bodies_str in the "test category/body changes" test.

Fixes #2181.
@davea davea closed this as completed in 08e335c Oct 17, 2018
@ghost ghost removed the Reviewed label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davea davea

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davea @dracos @LouiseMySociety