Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customisation of manifest #2792

Closed
dracos opened this issue Dec 9, 2019 · 0 comments · Fixed by #2866
Closed

Allow customisation of manifest #2792

dracos opened this issue Dec 9, 2019 · 0 comments · Fixed by #2866
Assignees
Milestone

Comments

@dracos
Copy link
Member

dracos commented Dec 9, 2019

Depends on #2220

Allow bits of the manifest to be customisable, e.g. the theme colour, app logos, and so on.
This could also be used/expanded for e.g. favicon, HTML theme colour, and then to being able to customise basic logo/styling in admin itself, though having non-static stylesheets more of a challenge!

For starters, going by #2220 work (see manifest commit on pwa branch), an admin page that lets you set, for a cobrand:

  • name
  • short_name
  • theme_colour
  • background_colour
  • Icons (192 and 512 are defaults, but perhaps any square multiple of 48), saved in web/theme/*moniker*/icons/ maybe?

I'd guess a theme database table with cobrand/key/value columns? Or cobrand and those things as columns if we don't think it's going to extend a lot...

Then that'd be picked up for the manifest. After that exists, it could set the theme colour in the HTML head (as fixmystreet.com cobrand does manually at present), and also then favicon would be next step, new ticket by then though I'd say!

@dracos dracos added this to the Mobile work milestone Dec 9, 2019
@davea davea self-assigned this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants