Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staff editing verified phone numbers (0.5d) #3295

Closed
dracos opened this issue Jan 22, 2021 · 0 comments · Fixed by #3525
Closed

Staff editing verified phone numbers (0.5d) #3295

dracos opened this issue Jan 22, 2021 · 0 comments · Fixed by #3525
Assignees
@MorayMySoc

Comments

@dracos
Copy link
Member

dracos commented Jan 22, 2021

Staff users can, when reporting as another user, create a verified phone account with a landline number. Editing that later in the admin, it currently won't let you edit anything because verified numbers have to be mobile. The admin should either let staff put whatever they want as a verified number, or at least, if you haven't edited an existing user's phone number, it shouldn't be erroring if you try and edit something else for that user.
@LouiseMySociety LouiseMySociety changed the title Staff editing verified phone numbers Staff editing verified phone numbers (1h) Mar 9, 2021
@LouiseMySociety LouiseMySociety changed the title Staff editing verified phone numbers (1h) Staff editing verified phone numbers (0.5d) Mar 9, 2021
mysociety-pusher pushed a commit that referenced this issue Jul 9, 2021
@MorayMySoc
Fix allows admin to edit user with verified landline
728d20a 
#3295

* Stops validation of phone number on user edit
if edit does not change phone number

* Adds test to check changing name does not
revalidate phone number so edit is successful

* Adds test to check that changing the number
revalidates the phone number
mysociety-pusher pushed a commit that referenced this issue Jul 9, 2021
@MorayMySoc
Fix allows admin to edit user with verified landline
cf60d4e 
#3295

* Stops validation of phone number on user edit
if edit does not change phone number

* Adds test to check changing name does not
revalidate phone number so edit is successful

* Adds test to check that changing the number
revalidates the phone number
@MorayMySoc MorayMySoc mentioned this issue Jul 9, 2021
Merged
@MorayMySoc MorayMySoc self-assigned this Jul 9, 2021
mysociety-pusher pushed a commit that referenced this issue Jul 9, 2021
@MorayMySoc
Fix allows admin to edit user with verified landline
e271bda 
#3295

* Stops validation of phone number on user edit
if edit does not change phone number

* Adds test to check changing name does not
revalidate phone number so edit is successful

* Adds test to check that changing the number
revalidates the phone number
dracos pushed a commit that referenced this issue Dec 3, 2021
@MorayMySoc @dracos
Fix allows admin to edit user with verified landline
0446854 
#3295

* Stops validation of phone number on user edit
if edit does not change phone number

* Adds test to check changing name does not
revalidate phone number so edit is successful

* Adds test to check that changing the number
revalidates the phone number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MorayMySoc MorayMySoc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove revalidation of verified landline number mysociety/fixmystreet
2 participants
@dracos @MorayMySoc