Have body.url work in hashref lookup. #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #2284 +/- ##
==========================================
- Coverage 80.14% 79.73% -0.42%
==========================================
Files 187 190 +3
Lines 12030 12131 +101
Branches 2223 2235 +12
==========================================
+ Hits 9642 9673 +31
- Misses 1628 1693 +65
- Partials 760 765 +5
Continue to review full report at Codecov.
|
dracos
force-pushed
the
body-hashref-working-url
branch
from
8aba251
to
a2859ad
Compare
body.url could still be in use by old-school /reports table index pages (though they were dropped in 2.1, so a cobrand would have to have overridden it since then) and the update to speed up body lists in #2248 broke it. This puts it back in minimal form.
dracos
force-pushed
the
body-hashref-working-url
branch
from
a2859ad
to
f8a4d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
body.urlcould still be in use by old-school/reportstable index pages (though they were dropped in 2.1, so a cobrand would have to have overridden it since then) and the update to speed up body lists in #2248 broke it. This puts it back in minimal form.I've removed the Norwegian note as they must have something different, the current code wouldn't be working for them either.