Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creation of two templates with same title. #2471

Merged
merged 1 commit into from
May 9, 2019

Conversation

dracos
Copy link
Member

@dracos dracos commented May 3, 2019

  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

Fixes https:/mysociety/fixmystreet-commercial/issues/1364

@ghost ghost assigned dracos May 3, 2019
@ghost ghost added the Reviewing label May 3, 2019
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #2471 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2471      +/-   ##
==========================================
+ Coverage   81.29%   81.31%   +0.01%     
==========================================
  Files         197      197              
  Lines       12639    12645       +6     
  Branches     2348     2350       +2     
==========================================
+ Hits        10275    10282       +7     
+ Misses       1579     1578       -1     
  Partials      785      785
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Admin.pm 80.48% <100%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fd2a0...0236d3a. Read the comment docs.

@dracos dracos requested a review from davea May 8, 2019 14:51
Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants