Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t reveal private report lat/lon in ‘report another’ link #2605

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

davea
Copy link
Member

@davea davea commented Aug 19, 2019

Adds a check to the template that generates the 'report another problem here' link to stop that link being generated if the report is non_public.

Please check the following:

  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

@davea davea requested a review from dracos August 19, 2019 10:28
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺

@davea davea merged commit 23bfb61 into master Aug 19, 2019
@github-pages github-pages bot temporarily deployed to github-pages August 19, 2019 10:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants