Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also check filter_category for category choice. #2893

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

dracos
Copy link
Member

@dracos dracos commented Feb 25, 2020

If you submit the non-JS image map from an around page with a particular
category selected, that is sent to the server in filter_category and
should be checked to see if we can pre-fill the category dropdown on new
report.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #2893 into master will decrease coverage by 22.81%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2893       +/-   ##
===========================================
- Coverage   82.85%   60.04%   -22.82%     
===========================================
  Files         235      234        -1     
  Lines       14929    14910       -19     
  Branches     2783     2781        -2     
===========================================
- Hits        12370     8953     -3417     
- Misses       1655     4955     +3300     
- Partials      904     1002       +98
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Report/New.pm 60.2% <100%> (-30.28%) ⬇️
perllib/FixMyStreet/DB/Result/AdminLog.pm 8.69% <0%> (-86.96%) ⬇️
...ib/FixMyStreet/DB/Result/ModerationOriginalData.pm 10.38% <0%> (-81.82%) ⬇️
perllib/FixMyStreet/App/Controller/Admin/Roles.pm 16.36% <0%> (-81.82%) ⬇️
perllib/FixMyStreet/App/Controller/Auth/Profile.pm 16.94% <0%> (-81.36%) ⬇️
...erllib/FixMyStreet/App/Controller/Questionnaire.pm 11.45% <0%> (-80.92%) ⬇️
perllib/FixMyStreet/App/Controller/Admin/States.pm 13.72% <0%> (-78.44%) ⬇️
perllib/FixMyStreet/App/Controller/Auth/Phone.pm 14.58% <0%> (-77.09%) ⬇️
...ib/FixMyStreet/App/Controller/Admin/DefectTypes.pm 15.09% <0%> (-75.48%) ⬇️
...llib/FixMyStreet/App/Controller/Admin/Templates.pm 8.33% <0%> (-73.81%) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6954823...11d77bf. Read the comment docs.

If you submit the non-JS image map from an around page with a particular
category selected, that is sent to the server in filter_category and
should be checked to see if we can pre-fill the category dropdown on new
report.
@dracos dracos requested a review from struan February 26, 2020 11:35
@dracos dracos force-pushed the check-filter_category-on-new branch from c058bfc to 11d77bf Compare February 26, 2020 11:35
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dracos dracos merged commit d65ce0e into master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants