Add Highways England junction lookup #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismytton
force-pushed
the
junction-lookup
branch
2 times, most recently
from
27f7695
to
e569c68
Compare
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
==========================================
- Coverage 83.11% 83.08% -0.04%
==========================================
Files 238 239 +1
Lines 15059 15079 +20
Branches 2805 2810 +5
==========================================
+ Hits 12516 12528 +12
- Misses 1641 1650 +9
+ Partials 902 901 -1
Continue to review full report at Codecov.
|
dracos
requested changes
Mar 11, 2020
chrismytton
force-pushed
the
junction-lookup
branch
from
e569c68
to
4aa67fb
Compare
chrismytton
force-pushed
the
junction-lookup
branch
from
4aa67fb
to
64358df
Compare
This is taken from the sort-my-sign repo. It allows the user to search for motorways names and junction numbers, e.g. "M60, Junction 2", and then geocodes that using a SQLite database created from Highways England markerpost locations.
chrismytton
force-pushed
the
junction-lookup
branch
from
64358df
to
a59ffd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taken from the sort-my-sign repo. It allows the user to search for motorways names and junction numbers, e.g. "M60, Junction 2", and then geocodes that using a SQLite database created from Highways England markerpost locations.
Fixes https:/mysociety/fixmystreet-commercial/issues/1797