Refactor send reports #2927
Merged
Refactor send reports #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
changed the base branch from
master
to
2788-open311-save-drop-extra-changes
Codecov Report
@@ Coverage Diff @@
## master #2927 +/- ##
==========================================
+ Coverage 83.05% 83.11% +0.06%
==========================================
Files 239 240 +1
Lines 15081 15094 +13
Branches 2810 2806 -4
==========================================
+ Hits 12526 12546 +20
- Misses 1652 1653 +1
+ Partials 903 895 -8
Continue to review full report at Codecov.
|
dracos
force-pushed
the
2788-open311-save-drop-extra-changes
branch
from
bf4308d
to
f4f24f7
Compare
dracos
force-pushed
the
refactor-send-reports
branch
from
325c583
to
7dff554
Compare
dracos
changed the base branch from
2788-open311-save-drop-extra-changes
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors send reports to not be one monolithic function, and moves the per-row processing to its own package for future use elsewhere. It also takes the 'verbose' end summary of failures out to its own script.