-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jQuery #3017
Upgrade jQuery #3017
Conversation
bc96d85
to
8900bb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
===========================================
- Coverage 82.55% 56.23% -26.33%
===========================================
Files 324 310 -14
Lines 21810 21051 -759
Branches 3283 3130 -153
===========================================
- Hits 18006 11837 -6169
- Misses 2757 8279 +5522
+ Partials 1047 935 -112
Continue to review full report at Codecov.
|
8900bb7
to
1547727
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tests pass, and I’ve checked it out and poked around locally. I wonder whether we should test the core javascript functionality in IE9 on BrowserStack, just to be sure that nothing we’ve done has affected support there? Seems unlikely, but you never know.
Nice to have stripped out all that IE6–8 cruft! And a more modern version of jQuery too. Lovely.
1547727
to
d2e4b6b
Compare
bf47d47
to
a1e6881
Compare
a1e6881
to
7bece02
Compare
e802f8b
to
986e531
Compare
986e531
to
ed950ee
Compare
ed950ee
to
a6191bb
Compare
53c6d0d
to
f72db98
Compare
86ac4c8
to
79a2179
Compare
Include some tests for the drawer opening.
Remove use of jQuery UI spinner entirely, and cut down the included jQuery UI CSS/JS to only the used autocomplete library.
79a2179
to
ba6788c
Compare
Does what it says on the tin.
I followed the jQuery upgrade instructions, and ran migrate alongside each upgrade, and fixed the obvious things. Not sure we can know whether everything has been caught.
I manually fixed issues in fancybox, we should do a comparator of similar more modern things and pick the nicest/smallest.
(diff is low because lots of the click() -> on('click') changes are within parts of the code not tested.)