Improve Bing geocoder results. #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3086 +/- ##
==========================================
+ Coverage 83.22% 83.34% +0.12%
==========================================
Files 246 246
Lines 15496 15502 +6
Branches 2894 2896 +2
==========================================
+ Hits 12896 12920 +24
+ Misses 1680 1656 -24
- Partials 920 926 +6
Continue to review full report at Codecov.
|
dracos
force-pushed
the
bing-locality
branch
2 times, most recently
from
5c0e120
to
2842dc2
Compare
Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple of parameters to hopefully improve results, and make sure the returned locality is included in the summary address.
Sometimes (I think with results with less information?), Bing is including no information beyond the country in the result string. Make sure the locality is included if not already present. Also ignore our server IP, and ask for 10 results (default was changed to 5 at some point).
Helps with this example query, at least, and I don't think it could harm any other.
Before:
After:
