Add option to check password on Have I Been Pwned. #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3095 +/- ##
==========================================
+ Coverage 83.26% 83.27% +0.01%
==========================================
Files 248 248
Lines 15559 15575 +16
Branches 2909 2910 +1
==========================================
+ Hits 12955 12970 +15
Misses 1676 1676
- Partials 928 929 +1
Continue to review full report at Codecov.
|
davea
approved these changes
Jul 5, 2020
If switched on, sends first five letters of the SHA1 hash of the entered password to HIBP's API, which then returns all matching hashes in their database of breached passwords. If we find a match, tell the user they need to pick a different password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If switched on, sends first five letters of the SHA1 hash of the entered
password to HIBP's API, which then returns all matching hashes in their
database of breached passwords. If we find a match, tell the user they
need to pick a different password.
Questions to answer - leave it like this, or if the count is very low, allow it to go through anyway? (Read the count section of https://www.troyhunt.com/ive-just-launched-pwned-passwords-version-2/ for background)
Future work - could on login check password against this and alert the user to change it if present?