Make anonymous comments clearer in alert emails

[chrismytton]

When showing a list of comments in HTML emails we previously didn't show anything for updates that were left anonymously. This led to some confusion about which text related to which update.

This change means that anonymous comments will show the text "Posted anonymously" next to them, which should make things a bit clearer.

Fixes https:/mysociety/fixmystreet-commercial/issues/2236

[chrismytton]

Manually testing this was a bit awkward. I ended up changing this line to have item_anonymous => 1 so all updates appeared as anonymous on /_dev/email/alert-update. There may be a better way!

fixmystreet/perllib/FixMyStreet/App/Controller/Develop.pm

Line 102 in 04de4f9

item_name => $u->name, item_anonymous => $u->anonymous, confirmed => $u->confirmed };

[codecov]

Codecov Report

Merging #3417 (7c52e55) into master (26e80bb) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head 7c52e55 differs from pull request most recent head 1f0e516. Consider uploading reports for the commit 1f0e516 to get more accurate results

@@            Coverage Diff             @@
##           master    #3417      +/-   ##
==========================================
- Coverage   82.51%   82.48%   -0.04%     
==========================================
  Files         325      325              
  Lines       21632    21633       +1     
  Branches     3263     3264       +1     
==========================================
- Hits        17849    17843       -6     
- Misses       2744     2750       +6     
- Partials     1039     1040       +1     

Impacted Files	Coverage Δ
perllib/FixMyStreet/App/Controller/Develop.pm	77.31% <50.00%> (-1.14%)	⬇️
web/cobrands/fixmystreet-uk-councils/alloy.js	86.13% <0.00%> (-4.96%)	⬇️
web/cobrands/fixmystreet/fixmystreet.js	70.68% <0.00%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e80bb...1f0e516. Read the comment docs.

[davea]

Nice and neat. Agreed that it's a bit awkward to test manually. I guess you could have the $q on L106 fetch updates from the report being displayed and fallback to the existing behaviour if there weren't any.

[chrismytton]

I guess you could have the $q on L106 fetch updates from the report being displayed and fallback to the existing behaviour if there weren't any.

@davea This works really well, thanks! I've added an extra commit to the end of this PR which does this, would you mind taking a look?

[davea]

Looks good! :)

(don't forget to check that fixamingata template and ack the cobrand-templates check)