-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect staff name & phone fields in FMS front-end. #3805
Conversation
280e493
to
9c2cf05
Compare
Codecov Report
@@ Coverage Diff @@
## master #3805 +/- ##
==========================================
+ Coverage 82.58% 82.78% +0.19%
==========================================
Files 353 352 -1
Lines 24278 24175 -103
Branches 3678 3676 -2
==========================================
- Hits 20050 20013 -37
+ Misses 3080 3014 -66
Partials 1148 1148
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but it e.g. breaks the "another user" option, and the test seems perhaps over-complicated for its needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying to simplify the test; it does not need to have special exception handling, please see my comment there. The fixes in staff.js look to have been copied/pasted leading to duplicate/incorrect val()
calls, and the new JS to call the staff set up won't work if you're not logged in as staff.
cbabfb4
to
c8fe2e5
Compare
c8fe2e5
to
1fedf46
Compare
1fedf46
to
9685714
Compare
9685714
to
95ec4c9
Compare
Name & phone fields for all staff are now disabled in the reporting and updating pages.
fixes mysociety/societyworks#2133
Please check the following:
Please check the contributing docs, and describe your pull request here.
Screenshots or GIF animations (using e.g. LICEcap) may be helpful.
Please include any issues that are fixed, using "fixes" or "closes" so that
they are auto-closed when the PR is merged.
Thanks for contributing!