Paginate alerts on user admin page #4158
Conversation
davea
force-pushed
the
admin-paginate-user-alerts
branch
from
c7474b0
to
63f5b55
Compare
Codecov Report
@@ Coverage Diff @@
## master #4158 +/- ##
==========================================
- Coverage 83.06% 83.06% -0.01%
==========================================
Files 360 360
Lines 26129 26118 -11
Branches 4029 4025 -4
==========================================
- Hits 21705 21694 -11
- Misses 3212 3213 +1
+ Partials 1212 1211 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -54,7 +54,13 @@ <h3>[% loc("User's alerts") %]</h3> | |||
| <td><input type="radio" name="edit_alert[[% alert.id %]]" value="delete"></td> | |||
| </tr> | |||
| [% END %] | |||
| <tr> | |||
| <td colspan=5></td> | |||
| <td colspan=3 class="center"> | |||
There was a problem hiding this comment.
You can use align="center" and not need any utility CSS ;)
| </form> | ||
| [% INCLUDE 'pagination.html', admin = 1, param = 'p', pager = alerts_pager %] |
There was a problem hiding this comment.
What is admin=1 for here? Hmm, I see it's there all the other places, so might as well leave it, but doesn't look like it does anything any more :)
There was a problem hiding this comment.
Hasn't done anything since 2016! Have removed it everywhere in f44b525.
davea
force-pushed
the
admin-paginate-user-alerts
branch
from
63f5b55
to
f44b525
Compare
Some shared/service user accounts have thousands of alerts and this page was timing out when attempting to render them all.
Prompted by FD-2538