-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility related smörgåsbord of things #4283
The head ref may contain hidden characters: "a-sm\u00F6rg\u00E5sbord-of-things"
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4283 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 359 359
Lines 26627 26625 -2
Branches 4128 4128
=======================================
- Hits 22137 22136 -1
+ Misses 3244 3243 -1
Partials 1246 1246
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9efb15d
to
c4f1a28
Compare
ab143e2
to
2721aa6
Compare
Hey @dracos Regarding this commit It doesn't retrieve the nearest address for me, I also tried using the button "Use my nearest location", but that didn't work either. Do I need to enable something? |
[Internal] inner counter
Pending commit: 21c6958 |
Sorry, wasn't clear what that's doing - on an /around or /reports list page, existing reports will have their closest address (if pre-calculated) added to their entry in their list, visually hidden. The pre-calculation only happens when a report is actually sent to a body, which is why you might not have any in your local development. |
Great thank Matthew, makes sense. |
No worries! A fieldset is to group related controls/labels (e.g. all the radio inputs for a particular question, or if you had a few text inputs all about parts of the user's address, say). I don't think it should be used to group every control within a form, that seems superfluous/confusing. In contact/index.html (and the other cases), I think that's what it's doing. This does make me realise additionally though that |
That makes sense =). Regarding the |
"I noticed that we do have a fieldset(wrapping the whole form) with not legend right after the form tag. Not sure where that it's coming from." - that's the one I've removed in this PR in templates/web/base/contact/form.html. |
@dracos Looks good. Before I approve, I wanted to check if some these files should also have fieldsets:
|
Yeah, looks like all of those should have a fieldset. |
Only one is shown at a time, so I think this was okay, but can be fixed easily enough.
2721aa6
to
235931e
Compare
Fixes https:/mysociety/societyworks/issues/3438
Fixes https:/mysociety/societyworks/issues/3436
Fixes https:/mysociety/societyworks/issues/3433
Fixes https:/mysociety/societyworks/issues/3432 (I think)
Fixes https:/mysociety/societyworks/issues/3430
Fixes https:/mysociety/societyworks/issues/3429