Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bexley] Make Whitespace API calls in parallel #5086

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrismytton
Copy link
Member

@chrismytton chrismytton commented Jul 30, 2024

To speed up the loading of a bin days page this changes some of the Whitespace API calls to be made in parallel, and then cached.

For https:/mysociety/societyworks/issues/4384

Todo

  • How long are things cached for?
  • Should we be cacheing worksheet lookups? Might want those to be up-to-date
  • Tests not passing

To speed up the loading of a bin days page this changes some of the
Whitespace API calls to be made in parallel, and then cached.
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (af8114f) to head (55e02a0).
Report is 2 commits behind head on master.

Files Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5086       +/-   ##
===========================================
- Coverage   82.65%   68.98%   -13.67%     
===========================================
  Files         403      401        -2     
  Lines       31401    31658      +257     
  Branches     4982     5100      +118     
===========================================
- Hits        25954    21839     -4115     
- Misses       3968     8325     +4357     
- Partials     1479     1494       +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant