Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve meaningful sequence in report page #5208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

Fixes: https:/mysociety/societyworks/issues/4560

Currently users using keyboard might miss that they can provide an update for a report, because the keyboard jumps straight to the key-tools like "Get udpates" which is at the bottom of the page. Also depending on the length of the report all the update related section might be down the bottom and invisible make it even less obvious that a user has elements they can interact with.

Please let me know if the changes in the order might cause some problems.

As a side note, the TFL audit also suggested to do the same in the /around page, which at first seems sensible, but when you have an area with a lot of reports the amount of keyboard navigation through the whole list of reports to reach to the "key-tools" make it really annoying. As an alternative if we wanted to implement this in the /around page would be to add an invisible link right before the list of reports that takes you to the "key-tools" div.

Screen.Recording.2024-10-07.at.09.25.33.mov

[skip changelog]

Currently users using keyboard might miss that they can provide an update for a report, because the keyboard jumps straight to the key-tools like "Get udpates" which is at the bottom of the page. Also depending on the length of the report all the update related section might be down the bottom and invisible make it even less obvious that a user has elements they can interact with.
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.34%. Comparing base (8053db7) to head (c71032b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5208      +/-   ##
==========================================
- Coverage   82.34%   82.34%   -0.01%     
==========================================
  Files         409      409              
  Lines       31845    31845              
  Branches     5063     5063              
==========================================
- Hits        26224    26223       -1     
- Misses       4124     4125       +1     
  Partials     1497     1497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant