-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipe 1 does not need dynamic payloads enabled to transmit ACK payloads #653
Comments
I inadvertently made a pun! 😄 |
This was referenced Oct 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following line of code from
enableAckPayload()
is a bit erroneous.write_register(DYNPD, read_register(DYNPD) | _BV(DPL_P1) | _BV(DPL_P0))
should be changed to
write_register(DYNPD, read_register(DYNPD) | _BV(DPL_P0))
Because enabling the dynamic payloads feature on pipe 1 is not needed to transmit ACK payloads, the configuration of pipe 1 should be left up to the user in this context. Of course, the examples should demonstrate proper pipe usage rather than letting the library hide (& probably confuse people about) the requirement to enable the dynamic payloads feature for pipes using ACK payloads in RX mode.
Examples/tests affected:
The note about this line of code in the docs should also be amended accordingly.
The text was updated successfully, but these errors were encountered: