Remove progmem macro overrides for ESP8266 (ESP8266 Arduino now supports them) #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure exactly when PROGMEM support was added to ESP8266 Arduino, but all of the necessary features are available:
http://esp8266.github.io/Arduino/versions/2.0.0-rc2/doc/reference.html#progmem
This PR removes the macro overrides that disable PROGMEM for ESP8266. I found that
PRIPSTRwas still necessary.Without this, pulling the RF24 library into an ESP8266 project clobbers the ability to use PROGMEM reliably.