Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call to txStandBy() in write_to_pipe #229

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add call to txStandBy() in write_to_pipe #229

merged 1 commit into from
Jun 17, 2024

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Jun 17, 2024

  • If a write fails while auto-ack is enabled using writeFast() there is a need to call txStandBy() or subsequent writes will fail. It also allows extra time for the current write to succeed. In initial testing most of the failed writes ended up being successful after calling txStandBy(txTimeout);

- If a write fails while auto-ack is enabled using `writeFast()` there is a need to call txStandBy() or subsequent writes will fail. It also allows extra time for the current write to succeed.
@TMRh20 TMRh20 marked this pull request as ready for review June 17, 2024 17:40
@TMRh20 TMRh20 requested a review from 2bndy5 June 17, 2024 17:41
@TMRh20 TMRh20 added the bug label Jun 17, 2024
@2bndy5
Copy link
Member

2bndy5 commented Jun 17, 2024

Well, this is a little embarrassing. I need to brush up on the context of this (seemingly simple) change. I forget how the FLAG_FAST_FRAG relates to auto-ack usage. At first glance, this LGTM, but I just want to be sure.

@TMRh20 TMRh20 merged commit decd8ce into master Jun 17, 2024
17 checks passed
@TMRh20 TMRh20 deleted the txStandBy branch June 17, 2024 19:56
2bndy5 pushed a commit that referenced this pull request Jun 17, 2024
- If a write fails while auto-ack is enabled using `writeFast()` there is a need to call txStandBy() or subsequent writes will fail. It also allows extra time for the current write to succeed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants