Add .dazelrc.local support #48
Conversation
| * A .dazelrc file in the current directory. | ||
| You can configure dazel in three ways (listed in order of lowest precedence to highest): | ||
| * A `.dazelrc` file in the current directory. | ||
| * A `.dazelrc.local` file in the current directory (this is for local user overrides - _should be .gitignored if used_). |
There was a problem hiding this comment.
I think it would make more sense to have the "local" file in the homedir (so that it'll be loaded from ~/.dazelrc.
It's the more standard way of doing that.
There was a problem hiding this comment.
I had considered that but at least for our use case it seems that these local overrides may/will change between projects which use dazel. I can change this if you feel that the local file in the $HOME dir makes the most sense, but perhaps it makes sense to have a few different levels of options.
Thoughts?
There was a problem hiding this comment.
I'm working on implementing this when I have a few minutes. Standby for updates
dazel.py
Outdated
| @@ -100,6 +101,7 @@ def __init__(self, instance_name, image_name, run_command, docker_command, docke | |||
| @classmethod | |||
| def from_config(cls): | |||
| config = cls._config_from_file() | |||
There was a problem hiding this comment.
Please pass the filename/env_var params here as well, and remove default values from the function. It will make things more explicit.
|
@mishas made those changes. Let me know what you think. |
|
Bump @mishas |
| # Build the expanded path for the config file and join it to the dazel_dir if | ||
| # necessary | ||
| expanded_path = os.path.expanduser(filename) | ||
| if expanded_path.startswith('/'): |
There was a problem hiding this comment.
Use consistent quotes (use double quotes here)
| @@ -99,7 +105,9 @@ def __init__(self, instance_name, image_name, run_command, docker_command, docke | |||
|
|
|||
| @classmethod | |||
| def from_config(cls): | |||
| config = cls._config_from_file() | |||
| config = {} | |||
| for (env_var, default_path) in DAZEL_RC_FILE_ENVS: | |||
|
Hello @markkohdev again, Sorry for the long wait on that. Thank you very much for your contribution, and again, sorry for the delay. |
|
It seems like this is a really small set of fixes, but I'm not sure if @markkohdev is still active. Is there some way for someone else to just push the changes? Can I make the changes in a new PR based on this one? |
|
@psigen , works for me, thanks for taking this on. |
This PR resolves #47
It adds the ability to provide dazel parameter overrides via a file called
.dazelrc.local. This is useful for things like mounting user-specific paths to dazel and overriding config values for some local enviroments (perhaps if some developers prefer different ports to be exposed than others).This
.dazelrc.localfile should be gitignored as mentioned in the readme since the purpose of it is to contain different values for different developers.