A fix for "show allowed values in help text" #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find `AllowedValuesAttribute` from all validators
|
Thanks for creating a PR. Can you describe more about what this is addressing? Also, can you add a test case? I don't see what is different between this change and the existing code. |
|
Sure I’ll add UT. |
Add UT. If there are multiple attribute validators, loop through them and try find `AllowedValuesAttribute`. The previous logic is to check the first attribute validator and see if it is `AllowedValuesAttribute` which is not correct.
|
If there are multiple attribute validators, loop through them and try find |
scott-xu
changed the title
scott-xu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up fix for #369
This fixes an issue where it only finds
AllowedValuesAttributefrom the first attribute validator.