Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update UseServerCertificateSelector to call the original selector #290

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

natemcmaster
Copy link
Owner

Resolves #122

This updates the default configuration of LettuceEncrypt to fallback to any existing certificate selector which may already be configured in Kestrel.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ba32cda) 44.30% compared to head (63feb2e) 44.50%.

Files Patch % Lines
...trel.Certificates/KestrelHttpsOptionsExtensions.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   44.30%   44.50%   +0.19%     
==========================================
  Files          51       51              
  Lines        1167     1173       +6     
  Branches      130      131       +1     
==========================================
+ Hits          517      522       +5     
  Misses        613      613              
- Partials       37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natemcmaster natemcmaster merged commit dbe32b5 into main Mar 30, 2024
8 of 10 checks passed
@natemcmaster natemcmaster deleted the fix/122 branch March 30, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests without SNI fail with: "The server mode SSL must use a certificate with the associated private key."
1 participant