[FIXED] PublishAsyncMaxPending not reset after server disconnect #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
force-pushed
the
fix-max-ack-pending
branch
2 times, most recently
from
343f6b7
to
41b750d
Compare
piotrpio
force-pushed
the
fix-max-ack-pending
branch
4 times, most recently
from
e5363a7
to
91dd87b
Compare
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
fix-max-ack-pending
branch
3 times, most recently
from
0116b0e
to
77c4c1c
Compare
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
fix-max-ack-pending
branch
from
77c4c1c
to
3399332
Compare
Merged
piotrpio
added a commit
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Piotr Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
PublishAsync()where pending acks were not being reset on disconnect. This caused the pending acks counter to grow (up to the limit) until connection is closed.