Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim whitespace from the parsed JWT #40

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Trim whitespace from the parsed JWT #40

merged 1 commit into from
Dec 14, 2022

Conversation

bruth
Copy link
Member

@bruth bruth commented Dec 14, 2022

Since the JWT is read from a file that may be produced programmatically
(in one form or another), it is possible for there to be one or more
additional whitespace surrounding the JWT in the decorated file. This
simply ensure the whitespace is trimmed as is performed when parsing the
seed value.

Signed-off-by: Byron Ruth [email protected]

Since the JWT is read from a file that may be produced programmatically
(in one form or another), it is possible for there to be one or more
additional whitespace surrounding the JWT in the decorated file. This
simply ensure the whitespace is trimmed as is performed when parsing the
seed value.

Signed-off-by: Byron Ruth <[email protected]>
@bruth bruth requested a review from aricart December 14, 2022 19:24
@coveralls
Copy link

coveralls commented Dec 14, 2022

Pull Request Test Coverage Report for Build 175

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.937%

Totals Coverage Status
Change from base Build 172: 0.0%
Covered Lines: 386
Relevant Lines: 489

💛 - Coveralls

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 6086451 into main Dec 14, 2022
@bruth bruth deleted the strip-jwt-ws branch December 14, 2022 19:58
@bruth
Copy link
Member Author

bruth commented Dec 14, 2022

A new release will need to be made to update the Go client and CLI. Should we wait until #38 is merged?

@derekcollison
Copy link
Member

Yes.

@derekcollison
Copy link
Member

Should be tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants