Don't send a Content-Length header for 204 (No Data) responses. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,7 +230,7 @@ TileServer.prototype.serve = function(req, http, callback) { | |||
| }, | |||
| function finalizeResult(callback) { | |||
| if (!result.headers) result.headers = {}; | |||
| result.headers['Content-Length'] = result.buffer ? result.buffer.length : 0; | |||
| result.headers['Content-Length'] = result.buffer && result.status !== 204 ? result.buffer.length : 0; | |||
There was a problem hiding this comment.
In these cases won't the buffer be empty, which would lead to a Content-Length of 0 already? If we're not wanting to send the header at all, wouldn't it need to be something more like this?
if (result.status !== 204) {
result.headers['Content-Length'] = result.buffer.length;
}
|
According to the RFC 7230 spec section 3.3.2 on content-length
Therefore the content-length header should not even appear. Anyone who relies on a content-length for a 204 HTTP status code is wrong. Judging by the title of this PR, I think brian's code suggestion is what you intended. |
|
Right, I updated the patch accordingly. |
|
Thanks @trasch! |
|
This is now out: 2.0.2 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients are quite picky about receiving 204 responses with a content-length header. This patch solves this by explicitly setting the Content-Length header to 0 for such responses (i.e. empty tiles).