Add workaround for empty logging race condition #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
requested review from
shawnvanderjagt and
jamesbursa
and removed request for
jamesbursa and
shawnvanderjagt
|
workaround doesn't seem to work. i'll try something else... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #258
Changes
see title
Context for reviewers
It seems that AWS recently introduced a change to the S3 service that created a race condition in the Terraform S3 provider that causes the S3 logging configuration to sometimes return an empty output when Terraform's AWS provider tries to read it. This causes the templata-infra CI to fail intermittently which is a pain since it also means that the template-infra CI can't clean up resources properly and that resources needed to be cleaned up manually.
This bug was reported on the terraform aws provider repo at hashicorp/terraform-provider-aws#31139
There seems to be a related PR on that repo created on April 24, 2023 that adds retries that should hopefully resolve this issue, but at time of writing (May 9, 2023) it has not yet been merged: hashicorp/terraform-provider-aws#30916
This PR adds the workaround documented in the first link.
I created #259 as a tech debt item to remove the workaround once proper fixes are ready
Testing
CI