Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote pull ontology process for zipped submissions #55

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented May 20, 2022

Bug fix

The do_remote_ontology_pull that fetches and parses new versions of ontologies if found. Does not work for zipped submissions.

It's because before creating a new submission, it checks if OWLAPI can parse the new file. But this test does not work for ZIP/GZIP files.

related

@syphax-bouazzouni syphax-bouazzouni changed the title Fix remote ontology process not if working if zipped Fix remote pull ontology process for zipped submissions May 20, 2022
@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/fix-zipped-sumbission-remote-pull branch from eca22b2 to 981bc2a Compare September 21, 2023 02:16
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #55 (981bc2a) into master (3fef501) will increase coverage by 0.42%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   53.95%   54.38%   +0.42%     
==========================================
  Files          15       15              
  Lines        1214     1210       -4     
==========================================
+ Hits          655      658       +3     
+ Misses        559      552       -7     
Flag Coverage Δ
unittests 54.38% <50.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/ncbo_cron/ontology_pull.rb 81.89% <50.00%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants