Amoral language

hints.md

@@ -249,7 +249,7 @@ Found:
 <br>
 Suggestion:
 <code>
-Perhaps you should remove it.
+You can remove it.
 </code>
 <br>
 </td>
@@ -1050,7 +1050,7 @@ do
 <br>
 Suggestion:
 <code>
-Perhaps you should remove it.
+You can remove it.
 </code>
 <br>
 </td>
@@ -1319,7 +1319,7 @@ where
 <br>
 Suggestion:
 <code>
-Perhaps you should remove it.
+You can remove it.
 </code>
 <br>
 Does not support refactoring.

src/Idea.hs

@@ -75,12 +75,13 @@ showIdeaANSI = showEx hsColourConsole
 showEx :: (String -> String) -> Idea -> String
 showEx tt Idea{..} = unlines $
  [showSrcSpan ideaSpan ++ ": " ++ (if ideaHint == "" then "" else show ideaSeverity ++ ": " ++ ideaHint)] ++
- f "Found" (Just ideaFrom) ++ f "Perhaps" ideaTo ++
+ f ideaFrom ++ maybe [] p ideaTo ++
  ["Note: " ++ n | let n = showNotes ideaNote, n /= ""]
  where
- f msg Nothing = []
- f msg (Just x) | null xs = [msg ++ " you should remove it."]
- | otherwise = (msg ++ ":") : map (" "++) xs
+ f x = ("Found" ++ ":") : map (" "++) (lines (tt x))
+
+ p x | null xs = ["You can remove it."]
+ | otherwise = ("Perhaps" ++ ":") : map (" "++) xs
  where xs = lines $ tt x
 
 

src/Summary.hs

@@ -177,7 +177,7 @@ showBuiltin BuiltinHint{..} = row1
  where
  eTo' = case eTo of
  Nothing -> ""
- Just "" -> "Perhaps you should remove it."
+ Just "" -> "You can remove it."
  Just s -> s
 
 lhsRhsTable :: [HintRule] -> [String]

tests/hint.test

@@ -26,7 +26,7 @@ OUTPUT
 tests/note.hs:1:1-32: Warning: Unused LANGUAGE pragma
 Found:
  {-# LANGUAGE RecordWildCards #-}
-Perhaps you should remove it.
+You can remove it.
 Note: may require `{-# LANGUAGE DisambiguateRecordFields #-}` adding to the top of the file
 
 tests/note.hs:5:11-24: Suggestion: Use null
@@ -219,13 +219,13 @@ OUTPUT
 tests/restricted-extension.hs:1:1-31: Warning: Unused LANGUAGE pragma
 Found:
  {-# LANGUAGE DeriveFoldable #-}
-Perhaps you should remove it.
+You can remove it.
 Note: Extension DeriveFoldable is implied by DeriveTraversable
 
 tests/restricted-extension.hs:2:1-30: Warning: Unused LANGUAGE pragma
 Found:
  {-# LANGUAGE DeriveFunctor #-}
-Perhaps you should remove it.
+You can remove it.
 Note: Extension DeriveFunctor is implied by DeriveTraversable
 
 tests/restricted-extension.hs:2:1-30: Warning: Avoid restricted extensions